-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#1117_-_Execute commands defined in edge model #1164
Feature/#1117_-_Execute commands defined in edge model #1164
Conversation
Codecov ReportBase: 87.51% // Head: 87.60% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1164 +/- ##
==========================================
+ Coverage 87.51% 87.60% +0.08%
==========================================
Files 199 199
Lines 6712 6744 +32
==========================================
+ Hits 5874 5908 +34
+ Misses 838 836 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
src/AzureIoTHub.Portal/Server/Controllers/v1.0/EdgeDevicesController.cs
Outdated
Show resolved
Hide resolved
src/AzureIoTHub.Portal/Client/Services/EdgeDeviceClientService.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not fan of having 2 endpoints :
- {deviceId}/{moduleName}/{methodName}
- {deviceId}/{moduleName}/custom/{methodName}
Would be preferable to have only {deviceId}/{moduleName}/{methodName}
Then if methodName is RestartModule the service should handle that on the edgeAgent module...
…ttps://github.com/CGI-FR/IoT-Hub-Portal into Feature/1117_Execute_commands_defined_in_edge_model
Description
What's new?
What kind of change does this PR introduce?