Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#1117_-_Execute commands defined in edge model #1164

Merged
merged 32 commits into from
Sep 7, 2022

Conversation

Sben65
Copy link
Contributor

@Sben65 Sben65 commented Sep 6, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Sorry, something went wrong.

@Sben65 Sben65 requested a review from a team as a code owner September 6, 2022 13:18
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Base: 87.51% // Head: 87.60% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (a730c10) compared to base (9774208).
Patch coverage: 96.42% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1164      +/-   ##
==========================================
+ Coverage   87.51%   87.60%   +0.08%     
==========================================
  Files         199      199              
  Lines        6712     6744      +32     
==========================================
+ Hits         5874     5908      +34     
+ Misses        838      836       -2     
Impacted Files Coverage Δ
.../Client/Pages/EdgeDevices/EdgeDeviceListPage.razor 79.36% <ø> (ø)
...ent/Pages/EdgeModels/EdgeModule/ModuleDialog.razor 100.00% <ø> (ø)
.../AzureIoTHub.Portal/Server/Helpers/ConfigHelper.cs 83.43% <ø> (-0.10%) ⬇️
...eIoTHub.Portal/Server/Services/EdgeModelService.cs 97.67% <ø> (ø)
...eIoTHub.Portal/Shared/Models/v1.0/IoTEdgeModule.cs 100.00% <ø> (ø)
...oTHub.Portal/Server/Services/EdgeDevicesService.cs 87.94% <90.90%> (-0.34%) ⬇️
...lient/Pages/EdgeDevices/EdgeDeviceDetailPage.razor 87.09% <100.00%> (+1.18%) ⬆️
....Portal/Client/Services/EdgeDeviceClientService.cs 100.00% <100.00%> (+13.33%) ⬆️
...l/Server/Controllers/v1.0/EdgeDevicesController.cs 100.00% <100.00%> (ø)
.../AzureIoTHub.Portal/Server/Helpers/DeviceHelper.cs 100.00% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment on lines +420 to +423
catch (Exception e)
{
throw new InternalServerErrorException($"Unable to execute the cloud to device method {method.MethodName} on the device with id {deviceId}", e);
}

Check notice

Code scanning / CodeQL

Generic catch clause

Generic catch clause.
@Sben65 Sben65 requested a review from kbeaugrand September 7, 2022 11:58
Copy link
Member

@kbeaugrand kbeaugrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fan of having 2 endpoints :

  • {deviceId}/{moduleName}/{methodName}
  • {deviceId}/{moduleName}/custom/{methodName}

Would be preferable to have only {deviceId}/{moduleName}/{methodName}

Then if methodName is RestartModule the service should handle that on the edgeAgent module...

@Sben65 Sben65 requested a review from kbeaugrand September 7, 2022 14:27

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…e_model
@kbeaugrand kbeaugrand enabled auto-merge (squash) September 7, 2022 14:37
@kbeaugrand kbeaugrand merged commit fa9aa17 into main Sep 7, 2022
@kbeaugrand kbeaugrand deleted the Feature/1117_Execute_commands_defined_in_edge_model branch September 7, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: [Edge device] - Execute commands defined in edge model
2 participants