Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: make nullable arguments as nullable in the declaration #1216

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

kbeaugrand
Copy link
Member

Description

What's new?

  • Refactor: make nullable arguments as nullable in the declaration

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand marked this pull request as ready for review September 11, 2022 17:29
@kbeaugrand kbeaugrand requested a review from a team as a code owner September 11, 2022 17:29
@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Base: 87.94% // Head: 87.94% // No change to project coverage 👍

Coverage data is based on head (5a33073) compared to base (abd2b38).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1216   +/-   ##
=======================================
  Coverage   87.94%   87.94%           
=======================================
  Files         213      213           
  Lines        6944     6944           
=======================================
  Hits         6107     6107           
  Misses        837      837           
Impacted Files Coverage Δ
...ureIoTHubPortal.Domain/Exceptions/BaseException.cs 100.00% <100.00%> (ø)
....Domain/Exceptions/InternalServerErrorException.cs 100.00% <100.00%> (ø)
...omain/Exceptions/ResourceAlreadyExistsException.cs 100.00% <100.00%> (ø)
...tal.Domain/Exceptions/ResourceNotFoundException.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand enabled auto-merge (squash) September 11, 2022 17:33
@kbeaugrand kbeaugrand disabled auto-merge September 11, 2022 17:42
@kbeaugrand kbeaugrand merged commit 29abad4 into main Sep 11, 2022
@kbeaugrand kbeaugrand deleted the fix/nullable_fields branch September 11, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant