Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backend to use database to manage device tags #1221 #1222

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Base: 87.90% // Head: 87.92% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (9acc09e) compared to base (2374916).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1222      +/-   ##
==========================================
+ Coverage   87.90%   87.92%   +0.01%     
==========================================
  Files         215      217       +2     
  Lines        6947     6923      -24     
==========================================
- Hits         6107     6087      -20     
+ Misses        840      836       -4     
Impacted Files Coverage Δ
...l.Infrastructure/Repositories/GenericRepository.cs 100.00% <ø> (ø)
...er/Controllers/v1.0/DeviceTagSettingsController.cs 100.00% <ø> (ø)
...reIoTHub.Portal/Shared/Models/v1.0/DeviceTagDto.cs 100.00% <ø> (ø)
...Infrastructure/Repositories/DeviceTagRepository.cs 100.00% <100.00%> (ø)
...AzureIoTHub.Portal/Client/Models/DeviceTagModel.cs 100.00% <100.00%> (ø)
...onfigurations/CreateDeviceConfigurationsPage.razor 53.46% <100.00%> (ø)
...Configurations/DeviceConfigurationDetailPage.razor 88.11% <100.00%> (ø)
...Portal/Client/Pages/Devices/CreateDevicePage.razor 70.74% <100.00%> (ø)
...Portal/Client/Pages/Devices/DeviceDetailPage.razor 79.51% <100.00%> (ø)
...b.Portal/Client/Pages/Devices/DeviceListPage.razor 72.27% <100.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

};

_ = this.mockDeviceTagRepository.Setup(repository => repository.GetByIdAsync(It.IsAny<string>()))
.ReturnsAsync((DeviceTag)null);

Check warning

Code scanning / CodeQL

Useless upcast

There is no need to upcast from [null](1) to [DeviceTag](2) - the conversion can be done implicitly.
@hocinehacherouf hocinehacherouf marked this pull request as ready for review September 12, 2022 12:10
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner September 12, 2022 12:10
@kbeaugrand kbeaugrand merged commit e475af5 into main Sep 12, 2022
@kbeaugrand kbeaugrand deleted the feature/1221_update_backend_to_use_database_to_manage_device_tags branch September 12, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Update backend to use database to manage device tags
2 participants