Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing compute device model image uri #1248 #1251

Merged

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@hocinehacherouf hocinehacherouf requested a review from a team as a code owner September 16, 2022 09:57
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 88.23% // Head: 88.23% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c51a78a) compared to base (791c467).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1251   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files         222      222           
  Lines        6831     6836    +5     
=======================================
+ Hits         6027     6032    +5     
  Misses        804      804           
Impacted Files Coverage Δ
...oTHub.Portal/Server/Services/DeviceModelService.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hocinehacherouf hocinehacherouf merged commit 68ce3a6 into main Sep 16, 2022
@hocinehacherouf hocinehacherouf deleted the bugfix/1248_device_model_image_not_displayed_listing branch September 16, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Device model image not displayed in list
2 participants