Fix loading device model properties on a device #1249 #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 88.23% // Head: 88.22% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1253 +/- ##
==========================================
- Coverage 88.23% 88.22% -0.02%
==========================================
Files 222 222
Lines 6836 6826 -10
==========================================
- Hits 6032 6022 -10
Misses 804 804
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| _ = this.mockTableClientFactory.Setup(c => c.GetDeviceTemplates()) | ||
| .Returns(this.mockDeviceTemplatesTableClient.Object); | ||
| _ = this.mockDeviceModelRepository.Setup(repository => repository.GetByIdAsync(It.IsAny<string>())) | ||
| .ReturnsAsync((DeviceModel)null); |
Check warning
Code scanning / CodeQL
Useless upcast
Comment on lines
+62
to
+64
| return deviceModelEntity == null | ||
| ? throw new ResourceNotFoundException($"The device model {deviceModelId} doesn't exist") | ||
| : true; |
Check notice
Code scanning / CodeQL
Unnecessarily complex Boolean expression
kbeaugrand
approved these changes
Sep 16, 2022
kbeaugrand
deleted the
bugfix/1249_fix_loading_device_model_properties_on_device
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What's new?
What kind of change does this PR introduce?