Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs about unit tests practices #1168 #1272

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Add docs about unit tests practices #1168 #1272

merged 2 commits into from
Sep 22, 2022

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@hocinehacherouf hocinehacherouf marked this pull request as ready for review September 20, 2022 18:42
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner September 20, 2022 18:42
@hocinehacherouf hocinehacherouf linked an issue Sep 20, 2022 that may be closed by this pull request
Feature: Add dev documentation on best practices for unit testing of blazor components #1168
Closed
7 tasks
kbeaugrand
kbeaugrand requested changes Sep 22, 2022
View reviewed changes
Copy link
Member

@kbeaugrand kbeaugrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some English grammar or vocabulary checks that could be changed

docs/dev-guide/testing/unit-tests-common-practices.md Outdated Show resolved Hide resolved
docs/dev-guide/testing/unit-tests-common-practices.md Outdated Show resolved Hide resolved
docs/dev-guide/testing/unit-tests-common-practices.md Outdated Show resolved Hide resolved
docs/dev-guide/testing/unit-tests-common-practices.md Outdated Show resolved Hide resolved
docs/dev-guide/testing/unit-tests-common-practices.md Outdated Show resolved Hide resolved
docs/dev-guide/testing/unit-tests-on-blazor-components.md Outdated Show resolved Hide resolved
docs/dev-guide/testing/unit-tests-on-blazor-components.md Outdated Show resolved Hide resolved
docs/dev-guide/testing/unit-tests-common-practices.md Outdated Show resolved Hide resolved
docs/dev-guide/testing/unit-tests-common-practices.md Outdated Show resolved Hide resolved
docs/dev-guide/testing/unit-tests-common-practices.md Outdated Show resolved Hide resolved
@hocinehacherouf hocinehacherouf force-pushed the docs/feature/1168_add_doc_unit_testing branch from c8879c9 to 103d157 Compare September 22, 2022 07:50
@kbeaugrand kbeaugrand merged commit b365c2f into docs/main Sep 22, 2022
@kbeaugrand kbeaugrand deleted the docs/feature/1168_add_doc_unit_testing branch September 22, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbeaugrand kbeaugrand kbeaugrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add dev documentation on best practices for unit testing of blazor components
2 participants
@hocinehacherouf @kbeaugrand