Synchronize concentrators between Azure and DB #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 88.76% // Head: 88.80% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1313 +/- ##
==========================================
+ Coverage 88.76% 88.80% +0.03%
==========================================
Files 241 245 +4
Lines 7373 7457 +84
==========================================
+ Hits 6545 6622 +77
- Misses 828 835 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+55
to
+54
| catch (Exception e) | ||
| { | ||
| this.logger.LogError(e, "Sync concentrators job has failed"); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
audserraCGI
force-pushed
the
feature/1287_synchronize_concentrators_between_azure_and_db
branch
from
4daf624 to
6c770cd
Compare
| }); | ||
|
|
||
| _ = this.mockConcentratorRepository.Setup(repository => repository.GetByIdAsync(expectedTwinConcentrator.DeviceId)) | ||
| .ReturnsAsync((Concentrator)null); |
Check warning
Code scanning / CodeQL
Useless upcast
Sben65
approved these changes
Oct 7, 2022
audserraCGI
deleted the
feature/1287_synchronize_concentrators_between_azure_and_db
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What's new?
What kind of change does this PR introduce?