Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#1281_-_Syncronize edge device between IoT hub and portal database #1314

Conversation

Sben65
Copy link
Contributor

@Sben65 Sben65 commented Oct 6, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 88.80% // Head: 88.89% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (beade02) compared to base (fecd9f5).
Patch coverage: 94.61% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1314      +/-   ##
==========================================
+ Coverage   88.80%   88.89%   +0.09%     
==========================================
  Files         245      249       +4     
  Lines        7457     7585     +128     
==========================================
+ Hits         6622     6743     +121     
- Misses        835      842       +7     
Impacted Files Coverage Δ
...zureIoTHub.Portal/Server/Jobs/SyncEdgeDeviceJob.cs 90.66% <90.66%> (ø)
...nfrastructure/Repositories/EdgeDeviceRepository.cs 100.00% <100.00%> (ø)
...eIoTHub.Portal/Server/Mappers/EdgeDeviceProfile.cs 100.00% <100.00%> (ø)
...oTHub.Portal/Server/Services/EdgeDevicesService.cs 87.85% <100.00%> (-0.09%) ⬇️
...ub.Portal/Server/Services/ExternalDeviceService.cs 94.76% <100.00%> (+0.14%) ⬆️
...rc/AzureIoTHubPortal.Domain/Entities/EdgeDevice.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment on lines +62 to +65
catch (Exception e)
{
this.logger.LogError(e, "Sync devices job has failed");
}

Check notice

Code scanning / CodeQL

Generic catch clause

Generic catch clause.
Comment on lines +327 to +330
catch (Exception e)
{
throw new InternalServerErrorException($"Unable to get devices twins", e);
}

Check notice

Code scanning / CodeQL

Generic catch clause

Generic catch clause.
@Sben65 Sben65 force-pushed the Feature/#1281_Syncronize_Edge_device_between_IoT_Hub_and_Portal_database branch from d4666ab to c84e89e Compare October 6, 2022 22:15
@Sben65 Sben65 marked this pull request as ready for review October 7, 2022 06:37
@Sben65 Sben65 requested a review from a team as a code owner October 7, 2022 06:37
@Sben65 Sben65 force-pushed the Feature/#1281_Syncronize_Edge_device_between_IoT_Hub_and_Portal_database branch from c84e89e to beade02 Compare October 7, 2022 10:08
@hocinehacherouf hocinehacherouf merged commit 0d499bc into main Oct 7, 2022
@hocinehacherouf hocinehacherouf deleted the Feature/#1281_Syncronize_Edge_device_between_IoT_Hub_and_Portal_database branch October 7, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Synchronize Edge Devices between IoT Hub and Portal database
3 participants