Change GatewayID field to list in device creation/edition pages #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 89.29% // Head: 89.40% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1376 +/- ##
==========================================
+ Coverage 89.29% 89.40% +0.11%
==========================================
Files 252 254 +2
Lines 7884 7960 +76
==========================================
+ Hits 7040 7117 +77
+ Misses 844 843 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+41
to
+44
| catch (Exception e) | ||
| { | ||
| this.logger.LogError(e, "Sync GatewayID job has failed"); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
Comment on lines
+703
to
+706
| catch (Exception e) | ||
| { | ||
| throw new InternalServerErrorException($"Unable to get GatewayIDs", e); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
…ub.com:CGI-FR/iot-hub-portal into 1171_change_gateway_id_field_in_device_details
…ub.com:CGI-FR/iot-hub-portal into 1171_change_gateway_id_field_in_device_details
hocinehacherouf
approved these changes
Oct 21, 2022
audserraCGI
deleted the
1171_change_gateway_id_field_in_device_details
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What's new?
What kind of change does this PR introduce?