Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1388 - Make Edge device Scope nullable in database #1389

Merged
merged 1 commit into from
Oct 23, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Oct 23, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand force-pushed the fix/#1388_make_edge_device_scope_nullable branch from 8de8070 to 706c8ea Compare October 23, 2022 14:26
@kbeaugrand kbeaugrand marked this pull request as ready for review October 23, 2022 14:26
@kbeaugrand kbeaugrand requested a review from a team as a code owner October 23, 2022 14:26
@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Base: 89.40% // Head: 89.40% // No change to project coverage 👍

Coverage data is based on head (706c8ea) compared to base (e57ff14).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1389   +/-   ##
=======================================
  Coverage   89.40%   89.40%           
=======================================
  Files         254      254           
  Lines        7960     7960           
=======================================
  Hits         7117     7117           
  Misses        843      843           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand enabled auto-merge (squash) October 23, 2022 14:33
@kbeaugrand kbeaugrand disabled auto-merge October 23, 2022 14:55
@kbeaugrand kbeaugrand merged commit 8d98d21 into main Oct 23, 2022
@kbeaugrand kbeaugrand deleted the fix/#1388_make_edge_device_scope_nullable branch October 23, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Failed to create an edge device
1 participant