Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize projects directories #1393

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Reorganize projects directories #1393

merged 1 commit into from
Oct 25, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Oct 23, 2022 •
edited
Loading

Description

What's new?

  • Refactor project directories

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand force-pushed the refactor/reorganize_directories branch 2 times, most recently from 51951d8 to 3337bd7 Compare October 23, 2022 15:54
@kbeaugrand kbeaugrand marked this pull request as ready for review October 23, 2022 15:54
@kbeaugrand kbeaugrand requested a review from a team as a code owner October 23, 2022 15:54
@kbeaugrand kbeaugrand force-pushed the refactor/reorganize_directories branch 2 times, most recently from 6e0e79e to 04f7c5a Compare October 23, 2022 17:01
@codecov
Copy link

codecov bot commented Oct 23, 2022 •
edited
Loading

Codecov Report

Base: 89.50% // Head: 89.50% // No change to project coverage 👍

Coverage data is based on head (5b6c6b2) compared to base (365de5f).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1393   +/-   ##
=======================================
  Coverage   89.50%   89.50%           
=======================================
  Files         256      256           
  Lines        8030     8030           
=======================================
  Hits         7187     7187           
  Misses        843      843
Impacted Files Coverage Δ
src/AzureIoTHub.Portal.Client/App.razor 0.00% <ø> (ø)
src/AzureIoTHub.Portal.Client/Constants/Theme.cs 100.00% <ø> (ø)
....Portal.Client/Converters/StringToBoolConverter.cs 100.00% <ø> (ø)
...ortal.Client/Exceptions/ProblemDetailsException.cs 100.00% <ø> (ø)
...ub.Portal.Client/Extensions/EnumerableExtension.cs 83.33% <ø> (ø)
...rtal.Client/Extensions/ProblemDetailsExtensions.cs 100.00% <ø> (ø)
...ub.Portal.Client/Handlers/ProblemDetailsHandler.cs 100.00% <ø> (ø)
...AzureIoTHub.Portal.Client/Models/DeviceTagModel.cs 100.00% <ø> (ø)
...lient/Models/ProblemDetailsWithExceptionDetails.cs 100.00% <ø> (ø)
...ureIoTHub.Portal.Client/Pages/Authentication.razor 0.00% <ø> (ø)
... and 280 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand force-pushed the refactor/reorganize_directories branch from 04f7c5a to 2b7cef1 Compare October 23, 2022 17:09
@kbeaugrand kbeaugrand force-pushed the refactor/reorganize_directories branch from 2b7cef1 to 5b6c6b2 Compare October 25, 2022 06:08
@kbeaugrand kbeaugrand merged commit 3419e4b into main Oct 25, 2022
@kbeaugrand kbeaugrand deleted the refactor/reorganize_directories branch October 25, 2022 06:15
kbeaugrand added a commit that referenced this pull request Oct 25, 2022
@kbeaugrand
Reorganize projects directories (#1393)
88469a5
kbeaugrand added a commit that referenced this pull request Oct 25, 2022
@Sben65 @kbeaugrand
Bug/1399_-_After duplicating an edge device, clicking on "New" keeps …
c5fb09f 
…duplication options (#1414)

* Reorganize projects directories (#1393)

* resolve #1399

Co-authored-by: Kevin BEAUGRAND <9513635+kbeaugrand@users.noreply.github.com>
kbeaugrand added a commit that referenced this pull request Oct 25, 2022
@kbeaugrand
Reorganize projects directories (#1393)
6086f34
kbeaugrand added a commit that referenced this pull request Oct 25, 2022
@Sben65 @kbeaugrand
Bug/1402_-_Edge device name not modifiable (#1411)
ff78d79 
* Reorganize projects directories (#1393)

* resolve #1402

* added a test line to verify the presence of the DeviceName field

* update unit test

Co-authored-by: Kevin BEAUGRAND <9513635+kbeaugrand@users.noreply.github.com>
kbeaugrand added a commit that referenced this pull request Oct 25, 2022
@kbeaugrand
Reorganize projects directories (#1393)
32f8396
kbeaugrand added a commit that referenced this pull request Oct 25, 2022
@Sben65 @kbeaugrand
Bug/1403_-_When creating a new edge device, the model image is not di…
3db396a 
…splayed (#1413)

* Reorganize projects directories (#1393)

* resolve #1403

* add new test to verify that the model image is displayed on the page

* delete useless assignement

Co-authored-by: Kevin BEAUGRAND <9513635+kbeaugrand@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kbeaugrand