Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1416 - Enable setting container create options on system modules in edge models #1418

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

kbeaugrand
Copy link
Member

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 89.57% // Head: 89.57% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (51730be) compared to base (3db396a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1418   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files         256      256           
  Lines        8039     8041    +2     
=======================================
+ Hits         7201     7203    +2     
  Misses        838      838           
Impacted Files Coverage Δ
...Client/Pages/EdgeModels/CreateEdgeModelsPage.razor 80.37% <ø> (ø)
...ges/EdgeModels/EdgeModule/SystemModuleDialog.razor 100.00% <100.00%> (ø)
.../AzureIoTHub.Portal.Server/Helpers/ConfigHelper.cs 87.03% <100.00%> (ø)
...Portal.Shared/Models/v1.0/EdgeModelSystemModule.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sben65 Sben65 merged commit b44a21f into main Oct 26, 2022
@Sben65 Sben65 deleted the fix/1416 branch October 26, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: When configuring edge model I should be able to set also the container create options on system modules
3 participants