Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix/1415_-_Unable to configure system modules on existing edge models #1420

Conversation

Sben65
Copy link
Contributor

@Sben65 Sben65 commented Oct 26, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 89.57% // Head: 89.63% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (88f60fc) compared to base (1ce4299).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1420      +/-   ##
==========================================
+ Coverage   89.57%   89.63%   +0.05%     
==========================================
  Files         256      256              
  Lines        8041     8082      +41     
==========================================
+ Hits         7203     7244      +41     
  Misses        838      838              
Impacted Files Coverage Δ
....Client/Pages/EdgeModels/EdgeModelDetailPage.razor 82.83% <100.00%> (+1.38%) ⬆️
...zureIoTHub.Portal.Server/Services/ConfigService.cs 100.00% <100.00%> (ø)
...eIoTHub.Portal.Server/Services/EdgeModelService.cs 98.67% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sben65 Sben65 changed the title BugFix/1415_-_Unable to configure system modules on existing edge models BugFix/1415_-_Unable configure system modules on existing edge models Oct 26, 2022
@Sben65 Sben65 force-pushed the Bug/1415_-_Unable_to_configure_system_modules_on_existing_edge_models branch from 70a8ef3 to 5db8312 Compare October 26, 2022 13:46
@Sben65 Sben65 marked this pull request as ready for review October 26, 2022 13:51
@Sben65 Sben65 requested a review from a team as a code owner October 26, 2022 13:51
@kbeaugrand kbeaugrand force-pushed the Bug/1415_-_Unable_to_configure_system_modules_on_existing_edge_models branch from 5db8312 to 88f60fc Compare October 26, 2022 14:05
@kbeaugrand kbeaugrand enabled auto-merge (squash) October 26, 2022 14:05
@Sben65 Sben65 changed the title BugFix/1415_-_Unable configure system modules on existing edge models BugFix/1415_-_Unable to configure system modules on existing edge models Oct 26, 2022
@kbeaugrand kbeaugrand merged commit 3d6ff94 into main Oct 26, 2022
@kbeaugrand kbeaugrand deleted the Bug/1415_-_Unable_to_configure_system_modules_on_existing_edge_models branch October 26, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Unable to configure system modules on existing edge models
2 participants