Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump prometheus-net.AspNetCore from 6.0.0 to 7.0.0 in /src #1425

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 26, 2022

Bumps prometheus-net.AspNetCore from 6.0.0 to 7.0.0.

Release notes

Sourced from prometheus-net.AspNetCore's releases.

v7.0.0

  • .NET Core specific functionality now targeting .NET 6.0 or greater (all previous versions will be end of life by December 2022).
  • Relaxed the API restriction that forbade you to create multiple metrics with the same name but different label names. While this is a Prometheus anti-pattern, it is a standard pattern in other metrics technologies and we will allow it in the name of interoperability.
  • Added IMetricFactory.WithLabels() to define static labels per-factory and reduce the effort needed by users when defining static labels in specific scopes.
  • Added automatic metric expiration feature, to remove timeseries when they are no longer used after a while. This improves interoperability with other metrics technologies such as .NET Meters.
  • (Breaking change) Rewrite of the MeterAdapter functionality to bridge .NET 6 metrics to Prometheus. API remains equivalent, though options class changed. Output format (what metrics are published) is completely different. Now it translates metric names (instead of putting them in labels) and preserves tags (labels) provided via the .NET Meters API. Added sample project to demonstrate functionality. Ref #359
  • (Breaking change) Dropped support for .NET Standard 2.0 - now will target specifically .NET 6.0 and .NET Framework 4.6.2. This was already documented before but there was "unofficial" support also for .NET Standard remaining. This is now removed.
  • (Breaking change) EventCounterAdapter output format changed to translate counters to Prometheus metrics and to improve usability by publishing both counters and gauges from ambiguous event counters.
  • EventCounterAdapter and MeterAdapter are now enabled on startup by default.
  • Added some debug metrics to indicate the number of metric families, instances and timeseries being exported by prometheus-net.
  • Added typical benchmark results to readme for easy reference, and to show relative speed of the simple versus complex instruments.
  • (Breaking change) Removed MetricConfiguration.StaticLabels because it had negative performance impact on many code paths that did not use it. The same functionality can be manually implemented in user code. Static labels remain available on registry and factory level.
  • When a before-collection metrics update callback throws an exception, it is now logged and ignored instead of breaking all metrics collection.
  • EventCounterAdapter now defaults to Informational events only, for reduced performance overhead. Can be configured via callback.
Changelog

Sourced from prometheus-net.AspNetCore's changelog.

  • 7.0.0
  • .NET Core specific functionality now targeting .NET 6.0 or greater (all previous versions will be end of life by December 2022).
  • Relaxed the API restriction that forbade you to create multiple metrics with the same name but different label names. While this is a Prometheus anti-pattern, it is a standard pattern in other metrics technologies and we will allow it in the name of interoperability.
  • Added IMetricFactory.WithLabels() to define static labels per-factory and reduce the effort needed by users when defining static labels in specific scopes.
  • Added automatic metric expiration feature, to remove timeseries when they are no longer used after a while. This improves interoperability with other metrics technologies such as .NET Meters.
  • (Breaking change) Rewrite of the MeterAdapter functionality to bridge .NET 6 metrics to Prometheus. API remains equivalent, though options class changed. Output format (what metrics are published) is completely different. Now it translates metric names (instead of putting them in labels) and preserves tags (labels) provided via the .NET Meters API. Added sample project to demonstrate functionality. Ref #359
  • (Breaking change) Dropped support for .NET Standard 2.0 - now will target specifically .NET 6.0 and .NET Framework 4.6.2. This was already documented before but there was "unofficial" support also for .NET Standard remaining. This is now removed.
  • (Breaking change) EventCounterAdapter output format changed to translate counters to Prometheus metrics and to improve usability by publishing both counters and gauges from ambiguous event counters.
  • EventCounterAdapter and MeterAdapter are now enabled on startup by default.
  • Added some debug metrics to indicate the number of metric families, instances and timeseries being exported by prometheus-net.
  • Added typical benchmark results to readme for easy reference, and to show relative speed of the simple versus complex instruments.
  • Removed MetricConfiguration.StaticLabels because it had negative performance impact on many code paths that did not use it. The same functionality can be manually implemented in user code. Static labels remain available on registry and factory level.
  • When a before-collection metrics update callback throws an exception, it is now logged and ignored instead of breaking all metrics collection.
  • EventCounterAdapter now defaults to Informational events only, for reduced performance overhead. Can be configured via callback.
Commits
  • 75cc817 Default to EventKeywords.None
  • cbb305a - EventCounterAdapter now defaults to Informational events only, for reduced ...
  • 5a44ada Fix bad code
  • db9b141 When a before-collection metrics update callback throws an exception, it is n...
  • 4f9f19c Add new labelNames ctor also to Metrics class
  • 06c5932 Have adapters catch any exceptions from .NET runtime
  • a7db416 fixx bugg
  • 2ef9aa6 CollectorIdentity debug ToString
  • 182b00c Fix StringSequence stack overflow
  • 4b8d3e7 Add debug metric to adapters: number of connected instruments
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [prometheus-net.AspNetCore](https://github.com/prometheus-net/prometheus-net) from 6.0.0 to 7.0.0.
- [Release notes](https://github.com/prometheus-net/prometheus-net/releases)
- [Changelog](https://github.com/prometheus-net/prometheus-net/blob/master/History)
- [Commits](prometheus-net/prometheus-net@v6.0.0...v7.0.0)

---
updated-dependencies:
- dependency-name: prometheus-net.AspNetCore
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner October 26, 2022 13:32
@dependabot dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file labels Oct 26, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 89.57% // Head: 89.57% // No change to project coverage 👍

Coverage data is based on head (05955c9) compared to base (f57c699).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1425   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files         256      256           
  Lines        8041     8041           
=======================================
  Hits         7203     7203           
  Misses        838      838           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand merged commit 1ce4299 into main Oct 26, 2022
@kbeaugrand kbeaugrand deleted the dependabot/nuget/src/prometheus-net.AspNetCore-7.0.0 branch October 26, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant