Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1467 - Failed to save LoRa WAN device model commands #1468

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Oct 28, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand marked this pull request as ready for review October 28, 2022 05:49
@kbeaugrand kbeaugrand requested a review from a team as a code owner October 28, 2022 05:49
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 89.59% // Head: 89.59% // No change to project coverage 👍

Coverage data is based on head (a0a87d4) compared to base (bf921a1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1468   +/-   ##
=======================================
  Coverage   89.59%   89.59%           
=======================================
  Files         256      256           
  Lines        8064     8064           
=======================================
  Hits         7225     7225           
  Misses        839      839           
Impacted Files Coverage Δ
...ub.Portal.Server/Services/LoRaWANCommandService.cs 96.36% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand merged commit 6a64290 into main Oct 28, 2022
@kbeaugrand kbeaugrand deleted the fix/1467_failed_to_save_device_model_commands branch October 28, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Failed to save LoRaWAN Device model
1 participant