Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1472 - Remove DeviceModelCommandManager class #1475

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Oct 28, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand force-pushed the refactor/remove_device_model_commands_manager branch 3 times, most recently from f623f23 to 0dac918 Compare October 28, 2022 10:02
@kbeaugrand kbeaugrand marked this pull request as ready for review October 28, 2022 10:03
@kbeaugrand kbeaugrand requested a review from a team as a code owner October 28, 2022 10:03
@kbeaugrand kbeaugrand force-pushed the refactor/remove_device_model_commands_manager branch from 0dac918 to 6023472 Compare October 28, 2022 10:07
@kbeaugrand kbeaugrand force-pushed the refactor/remove_device_model_commands_manager branch from 6023472 to ac525e2 Compare October 28, 2022 10:07
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 89.60% // Head: 89.58% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (6023472) compared to base (bf8c873).
Patch has no changes to coverable lines.

❗ Current head 6023472 differs from pull request most recent head ac525e2. Consider uploading reports for the commit ac525e2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1475      +/-   ##
==========================================
- Coverage   89.60%   89.58%   -0.03%     
==========================================
  Files         256      255       -1     
  Lines        8073     8038      -35     
==========================================
- Hits         7234     7201      -33     
+ Misses        839      837       -2     
Impacted Files Coverage Δ
...tal.Infrastructure/Factories/TableClientFactory.cs 90.00% <ø> (ø)
...oTHub.Portal.Shared/Models/v1.0/LoRaWAN/Command.cs 0.00% <0.00%> (-100.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand merged commit 393c73c into main Oct 28, 2022
@kbeaugrand kbeaugrand deleted the refactor/remove_device_model_commands_manager branch October 28, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring : Remove DeviceModelCommandManager
1 participant