Add an Export button for Devices list #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 89.70% // Head: 89.74% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1483 +/- ##
==========================================
+ Coverage 89.70% 89.74% +0.04%
==========================================
Files 256 259 +3
Lines 8011 8123 +112
==========================================
+ Hits 7186 7290 +104
- Misses 825 833 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kbeaugrand
reviewed
Oct 29, 2022
src/AzureIoTHub.Portal.Server/Controllers/v1.0/ImportExportController.cs
Outdated
Show resolved
Hide resolved
src/AzureIoTHub.Portal.Server/Controllers/v1.0/ImportExportController.cs
Outdated
Show resolved
Hide resolved
audserraCGI
changed the title
audserraCGI
force-pushed
the
add_import_and_export_devices_feature
branch
from
2d89b51 to
f709df8
Compare
kbeaugrand
force-pushed
the
add_import_and_export_devices_feature
branch
2 times, most recently
from
4c14030 to
fab8fb0
Compare
audserraCGI
force-pushed
the
add_import_and_export_devices_feature
branch
2 times, most recently
from
63156d2 to
e34964d
Compare
Comment on lines
+87
to
+106
| foreach (var item in list) | ||
| { | ||
| var deviceObject = JsonNode.Parse(item)!; | ||
|
|
||
| csvWriter.WriteField(deviceObject["deviceId"].ToString(), true); | ||
| csvWriter.WriteField(deviceObject["tags"]["deviceName"]?.ToString(), true); | ||
| csvWriter.WriteField(deviceObject["tags"]["modelId"]); | ||
|
|
||
| foreach (var tag in tags) | ||
| { | ||
| csvWriter.WriteField(string.Format(CultureInfo.InvariantCulture, $"{deviceObject!["tags"][tag]}")); | ||
| } | ||
|
|
||
| foreach (var property in properties) | ||
| { | ||
| csvWriter.WriteField(string.Format(CultureInfo.InvariantCulture, $"{deviceObject!["desired"][property]}")); | ||
| } | ||
|
|
||
| await csvWriter.NextRecordAsync(); | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Select
src/AzureIoTHub.Portal.Tests.Unit/Server/Controllers/v1.0/AdminControllerTests.cs
Fixed
Show fixed
Hide fixed
audserraCGI
force-pushed
the
add_import_and_export_devices_feature
branch
from
8921ecf to
293e671
Compare
hocinehacherouf
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What's new?
What kind of change does this PR introduce?