Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Code QL on ConfigService #1487

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Fix Code QL on ConfigService #1487

merged 1 commit into from
Oct 31, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Oct 31, 2022

Description

What's new?

  • Use dedicated exception handling in ConfigService

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand marked this pull request as ready for review October 31, 2022 07:21
@kbeaugrand kbeaugrand requested a review from a team as a code owner October 31, 2022 07:21
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 89.58% // Head: 89.54% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (a582d8a) compared to base (d459bd8).
Patch coverage: 88.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1487      +/-   ##
==========================================
- Coverage   89.58%   89.54%   -0.04%     
==========================================
  Files         255      255              
  Lines        8034     8034              
==========================================
- Hits         7197     7194       -3     
- Misses        837      840       +3     
Impacted Files Coverage Δ
...zureIoTHub.Portal.Server/Services/ConfigService.cs 98.55% <88.88%> (-1.45%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand merged commit 1bdc446 into main Oct 31, 2022
@kbeaugrand kbeaugrand deleted the fix/code_ql branch October 31, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant