Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix/#1421_-_Unable to delete device in database when the device did not exist in IoTHub #1499

Merged
merged 5 commits into from
Nov 2, 2022

Conversation

Sben65
Copy link
Contributor

@Sben65 Sben65 commented Nov 2, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@Sben65 Sben65 force-pushed the Bug/1421_-_Unable_to_delete_device_in_db branch from afe1dbe to 490fc85 Compare November 2, 2022 09:56
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 89.55% // Head: 89.57% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (6d6c0c2) compared to base (b7d2514).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1499      +/-   ##
==========================================
+ Coverage   89.55%   89.57%   +0.02%     
==========================================
  Files         255      255              
  Lines        8080     8099      +19     
==========================================
+ Hits         7236     7255      +19     
  Misses        844      844              
Impacted Files Coverage Δ
...eIoTHub.Portal.Server/Jobs/SyncConcentratorsJob.cs 93.33% <100.00%> (+0.60%) ⬆️
...c/AzureIoTHub.Portal.Server/Jobs/SyncDevicesJob.cs 93.06% <100.00%> (+0.67%) ⬆️
...zureIoTHub.Portal.Server/Jobs/SyncEdgeDeviceJob.cs 91.25% <100.00%> (+0.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sben65 Sben65 marked this pull request as ready for review November 2, 2022 10:51
@Sben65 Sben65 requested a review from a team as a code owner November 2, 2022 10:51
Copy link
Member

@kbeaugrand kbeaugrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only remove edge devices, you should also do the same with devices and concentrator please

@Sben65 Sben65 requested a review from kbeaugrand November 2, 2022 14:03
@kbeaugrand
Copy link
Member

LGTM

@kbeaugrand kbeaugrand merged commit f0ba7a1 into main Nov 2, 2022
@kbeaugrand kbeaugrand deleted the Bug/1421_-_Unable_to_delete_device_in_db branch November 2, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Unable to delete device in database when the device did not exist in IoTHub
2 participants