Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#1361_-_Add sort on edge models listing #1500

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

Sben65
Copy link
Contributor

@Sben65 Sben65 commented Nov 2, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 89.57% // Head: 89.58% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (1f0126c) compared to base (f0ba7a1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1500   +/-   ##
=======================================
  Coverage   89.57%   89.58%           
=======================================
  Files         255      255           
  Lines        8099     8101    +2     
=======================================
+ Hits         7255     7257    +2     
  Misses        844      844           
Impacted Files Coverage Δ
....Client/Pages/EdgeDevices/EdgeDeviceListPage.razor 81.81% <ø> (ø)
...al.Client/Pages/EdgeModels/EdgeModelListPage.razor 89.36% <100.00%> (+0.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sben65 Sben65 marked this pull request as ready for review November 2, 2022 14:12
@Sben65 Sben65 requested a review from a team as a code owner November 2, 2022 14:12
@Sben65 Sben65 force-pushed the Feature/1361_-_Add_sort_on_edge_models_listing branch from 4862375 to 1f0126c Compare November 2, 2022 14:12
@kbeaugrand
Copy link
Member

LGTM

@kbeaugrand kbeaugrand merged commit 15971e3 into main Nov 2, 2022
@kbeaugrand kbeaugrand deleted the Feature/1361_-_Add_sort_on_edge_models_listing branch November 2, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add sort on edge models listing
2 participants