Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1247_-_Catch all database exceptions #1520

Merged
merged 11 commits into from
Nov 11, 2022

Conversation

Sben65
Copy link
Contributor

@Sben65 Sben65 commented Nov 9, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 89.86% // Head: 89.95% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (c64a9e4) compared to base (3ffb8cb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1520      +/-   ##
==========================================
+ Coverage   89.86%   89.95%   +0.08%     
==========================================
  Files         256      256              
  Lines        8102     7995     -107     
==========================================
- Hits         7281     7192      -89     
+ Misses        821      803      -18     
Impacted Files Coverage Δ
....Client/Pages/EdgeDevices/EdgeDeviceListPage.razor 90.10% <100.00%> (+8.29%) ⬆️
...al.Server/Services/DeviceModelPropertiesService.cs 100.00% <100.00%> (ø)
...oTHub.Portal.Server/Services/DeviceModelService.cs 100.00% <100.00%> (ø)
...zureIoTHub.Portal.Server/Services/DeviceService.cs 100.00% <100.00%> (ø)
...oTHub.Portal.Server/Services/EdgeDevicesService.cs 98.83% <100.00%> (+2.59%) ⬆️
...eIoTHub.Portal.Server/Services/EdgeModelService.cs 100.00% <100.00%> (+1.37%) ⬆️
...ub.Portal.Server/Services/LoRaWANCommandService.cs 100.00% <100.00%> (+3.63%) ⬆️
...rtal.Server/Services/LoRaWANConcentratorService.cs 100.00% <100.00%> (ø)
...Hub.Portal.Server/Services/LoRaWanDeviceService.cs 100.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sben65 Sben65 force-pushed the Feature/1247_-_Catch_all_database_exceptions branch 2 times, most recently from 9e4f9c6 to 56da2ac Compare November 9, 2022 15:36
@Sben65 Sben65 force-pushed the Feature/1247_-_Catch_all_database_exceptions branch from 014289f to a4dcfdf Compare November 10, 2022 14:09
@Sben65 Sben65 marked this pull request as ready for review November 10, 2022 15:42
@Sben65 Sben65 requested a review from a team as a code owner November 10, 2022 15:42
Copy link
Member

@kbeaugrand kbeaugrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are also missing to configure the DbContext to use the ExceptionProcssor :

        optionsBuilder.UseExceptionProcessor();

This should be added at https://github.com/CGI-FR/IoT-Hub-Portal/blob/d394e3165f4084a9f28e2f06e7e55e52f7bbc431/src/AzureIoTHub.Portal.Infrastructure/PortalDbContext.cs#LL24-L29C10

@Sben65 Sben65 requested a review from kbeaugrand November 11, 2022 09:25
@kbeaugrand kbeaugrand merged commit 040eefe into main Nov 11, 2022
@kbeaugrand kbeaugrand deleted the Feature/1247_-_Catch_all_database_exceptions branch November 11, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Catch all database exceptions
2 participants