Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to .NET 7 #1521

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Upgrade to .NET 7 #1521

merged 1 commit into from
Nov 28, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Nov 9, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand force-pushed the feature/net7 branch 9 times, most recently from cd6b8fa to 99bd97c Compare November 10, 2022 11:44
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@kbeaugrand kbeaugrand force-pushed the feature/net7 branch 3 times, most recently from d7e7c9d to 6a3506e Compare November 17, 2022 12:51
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 89.69% // Head: 89.67% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (6a3506e) compared to base (7cd794a).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 6a3506e differs from pull request most recent head e1948ba. Consider uploading reports for the commit e1948ba to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1521      +/-   ##
==========================================
- Coverage   89.69%   89.67%   -0.03%     
==========================================
  Files         261      256       -5     
  Lines        8330     8013     -317     
==========================================
- Hits         7472     7186     -286     
+ Misses        858      827      -31     
Impacted Files Coverage Δ
...eIoTHub.Portal.Client/Shared/RedirectToLogin.razor 0.00% <0.00%> (ø)
...Portal.Client/Pages/Devices/DeleteDevicePage.razor 0.00% <0.00%> (-74.08%) ⬇️
...THub.Portal.Domain/Entities/DeviceModelProperty.cs 83.33% <0.00%> (-16.67%) ⬇️
...b.Portal.Client/Pages/Devices/DeviceListPage.razor 60.93% <0.00%> (-1.81%) ⬇️
...ub.Portal.Server/Services/ExternalDeviceService.cs 90.54% <0.00%> (-0.25%) ⬇️
...Portal.Client/Pages/Devices/DeviceDetailPage.razor 79.51% <0.00%> (-0.13%) ⬇️
...AzureIoTHub.Portal.Server/Mappers/DeviceProfile.cs 94.79% <0.00%> (-0.11%) ⬇️
src/AzureIoTHub.Portal.Client/Shared/Appbar.razor 76.19% <0.00%> (ø)
...zureIoTHub.Portal.Domain/Entities/LorawanDevice.cs 100.00% <0.00%> (ø)
...zureIoTHub.Portal.Server/Services/DeviceService.cs 100.00% <0.00%> (ø)
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand
Copy link
Member Author

After upgrading to .NET7, I'm facing an issue during the authentication.
This issue has been referenced at dotnet/aspnetcore#45187

@kbeaugrand kbeaugrand force-pushed the feature/net7 branch 3 times, most recently from d8e60dc to 6a7d1d4 Compare November 20, 2022 11:00
@kbeaugrand kbeaugrand force-pushed the feature/net7 branch 2 times, most recently from 3ef0f7e to 7d65dd4 Compare November 28, 2022 10:27
@kbeaugrand kbeaugrand marked this pull request as ready for review November 28, 2022 10:27
@kbeaugrand kbeaugrand requested a review from a team as a code owner November 28, 2022 10:27
@kbeaugrand kbeaugrand force-pushed the feature/net7 branch 3 times, most recently from c017915 to 0464c61 Compare November 28, 2022 18:04
@kbeaugrand kbeaugrand merged commit 66b8896 into main Nov 28, 2022
@kbeaugrand kbeaugrand deleted the feature/net7 branch November 28, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Migrate IoT Hub Portal to .NET 7
2 participants