Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Delete connected concentrators metric #1535

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 89.73% // Head: 89.70% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (6b74f92) compared to base (35dc9d2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1535      +/-   ##
==========================================
- Coverage   89.73%   89.70%   -0.03%     
==========================================
  Files         256      256              
  Lines        8034     8011      -23     
==========================================
- Hits         7209     7186      -23     
  Misses        825      825              
Impacted Files Coverage Δ
...rtal.Client/Pages/Dashboard/DashboardMetrics.razor 100.00% <ø> (ø)
...ub.Portal.Server/Services/ExternalDeviceService.cs 90.54% <ø> (-0.25%) ⬇️
...reIoTHub.Portal.Shared/Models/v1.0/PortalMetric.cs 100.00% <ø> (ø)
...ortal.Server/Jobs/ConcentratorMetricExporterJob.cs 100.00% <100.00%> (ø)
....Portal.Server/Jobs/ConcentratorMetricLoaderJob.cs 100.00% <100.00%> (ø)
...THub.Portal.Server/Jobs/DeviceMetricExporterJob.cs 100.00% <100.00%> (ø)
...IoTHub.Portal.Server/Jobs/DeviceMetricLoaderJob.cs 100.00% <100.00%> (ø)
....Portal.Server/Jobs/EdgeDeviceMetricExporterJob.cs 100.00% <100.00%> (ø)
...ub.Portal.Server/Jobs/EdgeDeviceMetricLoaderJob.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hocinehacherouf hocinehacherouf marked this pull request as ready for review November 14, 2022 20:51
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner November 14, 2022 20:51
@kbeaugrand kbeaugrand merged commit 3d9e857 into main Nov 15, 2022
@kbeaugrand kbeaugrand deleted the feature/1378_delete_connected_concentrators_metric branch November 15, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Delete connected concentrators metric
2 participants