Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1300 move blazor components from pages folder to components folder #1573

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Nov 21, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand marked this pull request as ready for review November 21, 2022 17:32
@kbeaugrand kbeaugrand requested a review from a team as a code owner November 21, 2022 17:32
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 89.74% // Head: 89.74% // No change to project coverage 👍

Coverage data is based on head (61a4bba) compared to base (20e766d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1573   +/-   ##
=======================================
  Coverage   89.74%   89.74%           
=======================================
  Files         259      259           
  Lines        8123     8123           
=======================================
  Hits         7290     7290           
  Misses        833      833           
Impacted Files Coverage Δ
.../Components/Dashboard/DashboardMetricCounter.razor 100.00% <ø> (ø)
...Client/Components/Dashboard/DashboardMetrics.razor 100.00% <ø> (ø)
...s/DeviceModels/LoRaWAN/CreateLoraDeviceModel.razor 97.43% <ø> (ø)
...nts/DeviceModels/LoRaWAN/EditLoraDeviceModel.razor 100.00% <ø> (ø)
...Components/Devices/DeviceToDuplicateSelector.razor 100.00% <ø> (ø)
.../Components/Devices/LoRaWAN/CreateLoraDevice.razor 92.00% <ø> (ø)
...nt/Components/Devices/LoRaWAN/EditLoraDevice.razor 92.45% <ø> (ø)
...ts/EdgeDevices/EdgeDeviceToDuplicateSelector.razor 100.00% <ø> (ø)
...ent/Pages/DeviceModels/CreateDeviceModelPage.razor 65.33% <ø> (ø)
...ent/Pages/DeviceModels/DeviceModelDetailPage.razor 69.44% <ø> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand merged commit e5981ee into main Nov 21, 2022
@kbeaugrand kbeaugrand deleted the feature/1300_Move_Blazor_components_from_pages_folder_to_components_folder branch November 21, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Move Blazor components from Pages folder to Components folder
1 participant