Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled Drs in router config must be set to disabled #1600

Merged

Conversation

ChristopheRib63
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@ChristopheRib63 ChristopheRib63 requested a review from a team as a code owner November 25, 2022 09:24
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 89.73% // Head: 89.73% // No change to project coverage 👍

Coverage data is based on head (bbbec85) compared to base (b130300).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1600   +/-   ##
=======================================
  Coverage   89.73%   89.73%           
=======================================
  Files         265      265           
  Lines        8396     8396           
=======================================
  Hits         7534     7534           
  Misses        862      862           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand
Copy link
Member

@ChristopheRib63, you should not remove the values.
The issue was to set the range disabled by changing its value to -1...

@kbeaugrand kbeaugrand self-requested a review November 25, 2022 10:07
@kbeaugrand kbeaugrand enabled auto-merge (squash) November 25, 2022 10:08
@kbeaugrand kbeaugrand merged commit adc8bd7 into main Nov 25, 2022
@kbeaugrand kbeaugrand deleted the Bug/1561_Disabled_DRs_in_router_config_must_be_set_to_disabled branch November 25, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Disabled DRs in router config must be set to disabled (-1) instead of FSK (0)
2 participants