Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1609 - Do not dispose the String content when updating the tag #1610

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Fix #1609 - Do not dispose the String content when updating the tag #1610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/AzureIoTHub.Portal.Client/Services/DeviceTagSettingsClientService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ public DeviceTagSettingsClientService(HttpClient http)
public Task CreateOrUpdateDeviceTag(DeviceTagDto deviceTag)
{
var deviceTagAsJson = JsonConvert.SerializeObject(deviceTag);
using var content = new StringContent(deviceTagAsJson, Encoding.UTF8, "application/json");
var content = new StringContent(deviceTagAsJson, Encoding.UTF8, "application/json");

Check warning

Code scanning / CodeQL

Missing Dispose call on local IDisposable

Disposable 'StringContent' is created but not disposed.

return this.http.PatchAsync("api/settings/device-tags", content);
}

Expand Down