Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label feature #777 #1621

Merged
merged 21 commits into from
Dec 5, 2022
Merged

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 89.87% // Head: 90.04% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (095a7d6) compared to base (0692b89).
Patch coverage: 94.82% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1621      +/-   ##
==========================================
+ Coverage   89.87%   90.04%   +0.17%     
==========================================
  Files         263      268       +5     
  Lines        8622     8834     +212     
==========================================
+ Hits         7749     7955     +206     
- Misses        873      879       +6     
Impacted Files Coverage Δ
...ent/Pages/DeviceModels/CreateDeviceModelPage.razor 65.33% <ø> (ø)
...ent/Pages/DeviceModels/DeviceModelDetailPage.razor 69.44% <ø> (ø)
...Portal.Client/Pages/Devices/CreateDevicePage.razor 70.74% <ø> (ø)
...Portal.Client/Pages/Devices/DeviceDetailPage.razor 79.64% <ø> (ø)
...lient/Pages/EdgeDevices/EdgeDeviceDetailPage.razor 88.20% <ø> (ø)
...Client/Pages/EdgeModels/CreateEdgeModelsPage.razor 80.90% <ø> (ø)
....Client/Pages/EdgeModels/EdgeModelDetailPage.razor 82.83% <ø> (ø)
...lient/Pages/EdgeDevices/CreateEdgeDevicePage.razor 83.11% <61.53%> (+2.56%) ⬆️
...b.Portal.Client/Pages/Devices/DeviceListPage.razor 62.24% <64.28%> (+0.15%) ⬆️
....Client/Pages/EdgeDevices/EdgeDeviceListPage.razor 88.57% <78.57%> (-1.54%) ⬇️
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hocinehacherouf hocinehacherouf force-pushed the feature/777_add_labels_on_devices_and_edges branch 2 times, most recently from c43c5aa to 4411cd2 Compare December 4, 2022 12:07
@hocinehacherouf hocinehacherouf force-pushed the feature/777_add_labels_on_devices_and_edges branch from 386314c to 25fc689 Compare December 4, 2022 14:28
@hocinehacherouf hocinehacherouf marked this pull request as ready for review December 4, 2022 20:16
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner December 4, 2022 20:16
@kbeaugrand kbeaugrand merged commit cf525a8 into main Dec 5, 2022
@kbeaugrand kbeaugrand deleted the feature/777_add_labels_on_devices_and_edges branch December 5, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants