Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1635 - discard device sync if its modelid is not provided #1636

Merged

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Dec 5, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner December 5, 2022 13:33
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 90.04% // Head: 90.09% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (7df6d3b) compared to base (b210968).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1636      +/-   ##
==========================================
+ Coverage   90.04%   90.09%   +0.04%     
==========================================
  Files         268      268              
  Lines        8834     8838       +4     
==========================================
+ Hits         7955     7963       +8     
+ Misses        879      875       -4     
Impacted Files Coverage Δ
...c/AzureIoTHub.Portal.Server/Jobs/SyncDevicesJob.cs 97.14% <100.00%> (+4.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand force-pushed the fix/1635_sync_device_failed_when_modelid_not_provided branch 2 times, most recently from 728be6c to cab6646 Compare December 5, 2022 14:00
@kbeaugrand kbeaugrand force-pushed the fix/1635_sync_device_failed_when_modelid_not_provided branch from cab6646 to 7df6d3b Compare December 5, 2022 14:05
@kbeaugrand kbeaugrand enabled auto-merge (squash) December 5, 2022 14:40
@kbeaugrand kbeaugrand merged commit 1787a88 into main Dec 5, 2022
@kbeaugrand kbeaugrand deleted the fix/1635_sync_device_failed_when_modelid_not_provided branch December 5, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: SyncDevices failed when modelId is not present on the tags
2 participants