Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display labels at the device list page #1638

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Dec 5, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 90.09% // Head: 90.12% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (559f5a4) compared to base (7ae6749).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1638      +/-   ##
==========================================
+ Coverage   90.09%   90.12%   +0.02%     
==========================================
  Files         268      269       +1     
  Lines        8838     8848      +10     
==========================================
+ Hits         7963     7974      +11     
+ Misses        875      874       -1     
Impacted Files Coverage Δ
...zureIoTHub.Portal.Domain/Entities/LorawanDevice.cs 100.00% <ø> (ø)
...THub.Portal.Client/Components/Commons/Labels.razor 100.00% <100.00%> (ø)
...lient/Pages/DeviceModels/DeviceModelListPage.razor 97.43% <100.00%> (ø)
...b.Portal.Client/Pages/Devices/DeviceListPage.razor 62.43% <100.00%> (+0.19%) ⬆️
....Client/Pages/EdgeDevices/EdgeDeviceListPage.razor 88.67% <100.00%> (+0.10%) ⬆️
...al.Client/Pages/EdgeModels/EdgeModelListPage.razor 89.36% <100.00%> (ø)
src/AzureIoTHub.Portal.Domain/Entities/Device.cs 100.00% <100.00%> (ø)
...l.Infrastructure/Repositories/GenericRepository.cs 100.00% <100.00%> (ø)
...eIoTHub.Portal.Server/Mappers/EdgeDeviceProfile.cs 100.00% <100.00%> (ø)
...oTHub.Portal.Server/Services/DeviceModelService.cs 100.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand force-pushed the feature/1637_display_device_labels_on_list branch 5 times, most recently from 9bf1d86 to bc88eb1 Compare December 5, 2022 16:55
@kbeaugrand kbeaugrand force-pushed the feature/1637_display_device_labels_on_list branch from bc88eb1 to 559f5a4 Compare December 5, 2022 17:02
@kbeaugrand kbeaugrand marked this pull request as ready for review December 5, 2022 17:05
@kbeaugrand kbeaugrand requested a review from a team as a code owner December 5, 2022 17:05
@hocinehacherouf hocinehacherouf merged commit 835d4aa into main Dec 5, 2022
@hocinehacherouf hocinehacherouf deleted the feature/1637_display_device_labels_on_list branch December 5, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Display device labels on the list screen
2 participants