Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Update devices pagination to distinguish devices that have telemetry #1641 #1658

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 90.13% // Head: 90.13% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d90e10c) compared to base (343de2d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1658   +/-   ##
=======================================
  Coverage   90.13%   90.13%           
=======================================
  Files         268      268           
  Lines        8840     8842    +2     
=======================================
+ Hits         7968     7970    +2     
  Misses        872      872           
Impacted Files Coverage Δ
...b.Portal.Client/Pages/Devices/DeviceListPage.razor 62.43% <100.00%> (ø)
...IoTHub.Portal.Server/Services/DeviceServiceBase.cs 97.36% <100.00%> (+0.01%) ⬆️
...IoTHub.Portal.Shared/Models/v1.0/DeviceListItem.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hocinehacherouf hocinehacherouf marked this pull request as ready for review December 8, 2022 17:23
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner December 8, 2022 17:23
@kbeaugrand kbeaugrand force-pushed the feaure/1641_inlude_telemetry_device_pagination branch from 424b4a3 to d90e10c Compare December 9, 2022 07:15
@kbeaugrand kbeaugrand enabled auto-merge (squash) December 9, 2022 07:15
@kbeaugrand kbeaugrand merged commit a7b271f into main Dec 9, 2022
@kbeaugrand kbeaugrand deleted the feaure/1641_inlude_telemetry_device_pagination branch December 9, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Devices pagination should includes telemetry
2 participants