Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default image of a new device model or edge model should be the d… #1684

Conversation

ChristopheRib63
Copy link
Contributor

@ChristopheRib63 ChristopheRib63 commented Dec 20, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 90.30% // Head: 90.32% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (9064d99) compared to base (93e9511).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1684      +/-   ##
==========================================
+ Coverage   90.30%   90.32%   +0.01%     
==========================================
  Files         268      268              
  Lines        8842     8855      +13     
==========================================
+ Hits         7985     7998      +13     
  Misses        857      857              
Impacted Files Coverage Δ
...Infrastructure/Managers/DeviceModelImageManager.cs 96.66% <100.00%> (+0.74%) ⬆️
...oTHub.Portal.Server/Services/DeviceModelService.cs 100.00% <100.00%> (ø)
...eIoTHub.Portal.Server/Services/EdgeModelService.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChristopheRib63 ChristopheRib63 marked this pull request as ready for review December 21, 2022 09:54
@ChristopheRib63 ChristopheRib63 requested a review from a team as a code owner December 21, 2022 09:54
@hocinehacherouf hocinehacherouf force-pushed the Fix/1649_The_default_image_of_a_new_device_model_or_edge_model_should_be_the_default_image branch from e54f835 to c9a47de Compare December 21, 2022 10:03
@hocinehacherouf hocinehacherouf enabled auto-merge (squash) December 21, 2022 10:11
@hocinehacherouf hocinehacherouf merged commit 2374b8e into main Dec 21, 2022
@hocinehacherouf hocinehacherouf deleted the Fix/1649_The_default_image_of_a_new_device_model_or_edge_model_should_be_the_default_image branch December 21, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: The default image of a new device model or edge model should be the default image
2 participants