Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1562 increase code coverage on device list page #1690

Merged

Conversation

ChristopheRib63
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Base: 90.39% // Head: 90.97% // Increases project coverage by +0.58% 🎉

Coverage data is based on head (734a9f4) compared to base (75465a3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1690      +/-   ##
==========================================
+ Coverage   90.39%   90.97%   +0.58%     
==========================================
  Files         270      270              
  Lines        8879     8855      -24     
==========================================
+ Hits         8026     8056      +30     
+ Misses        853      799      -54     
Impacted Files Coverage Δ
...b.Portal.Client/Pages/Devices/DeviceListPage.razor 88.43% <100.00%> (+26.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChristopheRib63 ChristopheRib63 marked this pull request as ready for review January 10, 2023 09:02
@ChristopheRib63 ChristopheRib63 requested a review from a team as a code owner January 10, 2023 09:02
@hocinehacherouf hocinehacherouf force-pushed the Fix/1562_Increase_code_coverage_on_DeviceListPage branch from ec0dc09 to 7c837a4 Compare January 12, 2023 10:56
@hocinehacherouf hocinehacherouf marked this pull request as draft January 12, 2023 10:56
@hocinehacherouf hocinehacherouf marked this pull request as ready for review January 12, 2023 13:14
@hocinehacherouf hocinehacherouf merged commit 9a99e76 into main Jan 12, 2023
@hocinehacherouf hocinehacherouf deleted the Fix/1562_Increase_code_coverage_on_DeviceListPage branch January 12, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Increase code coverage on DeviceListPage.razor
2 participants