Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search by name or description on edge models #1362 #1696

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 90.32% // Head: 90.39% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (08e4c41) compared to base (2e7f2cd).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1696      +/-   ##
==========================================
+ Coverage   90.32%   90.39%   +0.07%     
==========================================
  Files         268      270       +2     
  Lines        8855     8879      +24     
==========================================
+ Hits         7998     8026      +28     
+ Misses        857      853       -4     
Impacted Files Coverage Δ
...IoTHub.Portal.Server/Services/DeviceServiceBase.cs 97.36% <ø> (ø)
...oTHub.Portal.Server/Services/EdgeDevicesService.cs 98.95% <ø> (ø)
...tal.Shared/Models/v1.0/Filters/DeviceListFilter.cs 100.00% <ø> (ø)
...Shared/Models/v1.0/Filters/EdgeDeviceListFilter.cs 100.00% <ø> (ø)
...tal.Shared/Models/v1.0/Filters/PaginationFilter.cs 100.00% <ø> (ø)
...Client/Components/EdgeModels/EdgeModelSearch.razor 100.00% <100.00%> (ø)
...al.Client/Pages/EdgeModels/EdgeModelListPage.razor 98.03% <100.00%> (+8.67%) ⬆️
...b.Portal.Client/Services/EdgeModelClientService.cs 100.00% <100.00%> (ø)
...al.Server/Controllers/v1.0/EdgeModelsController.cs 100.00% <100.00%> (ø)
...eIoTHub.Portal.Server/Services/EdgeModelService.cs 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hocinehacherouf hocinehacherouf force-pushed the Feature/1362_allow_filter_edgemodels_by_name_or_description branch from 9db5b62 to f836d22 Compare January 9, 2023 10:12
@hocinehacherouf hocinehacherouf marked this pull request as ready for review January 9, 2023 11:28
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner January 9, 2023 11:28
@hocinehacherouf hocinehacherouf enabled auto-merge (squash) January 11, 2023 22:33
@hocinehacherouf hocinehacherouf merged commit 6bfee25 into main Jan 11, 2023
@hocinehacherouf hocinehacherouf deleted the Feature/1362_allow_filter_edgemodels_by_name_or_description branch January 11, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Allow filter edge models by name or description
1 participant