Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: remove blazored modal references #1738

Merged
merged 3 commits into from
Feb 6, 2023

Conversation

GuillaumeM-2ISA
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@GuillaumeM-2ISA GuillaumeM-2ISA requested a review from a team as a code owner February 6, 2023 10:09
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 90.97% // Head: 90.97% // No change to project coverage 👍

Coverage data is based on head (34dbd10) compared to base (69a37ad).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1738   +/-   ##
=======================================
  Coverage   90.97%   90.97%           
=======================================
  Files         270      270           
  Lines        8855     8855           
=======================================
  Hits         8056     8056           
  Misses        799      799           
Impacted Files Coverage Δ
src/AzureIoTHub.Portal.Client/App.razor 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hocinehacherouf hocinehacherouf force-pushed the Feature/1659_remove_blazored_modal branch from 72af94d to 75b5284 Compare February 6, 2023 14:55
Copy link
Contributor

@hocinehacherouf hocinehacherouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GuillaumeM-2ISA on App.razor, you have to remove the element CascadingBlazoredModal

@hocinehacherouf hocinehacherouf self-requested a review February 6, 2023 16:05
@hocinehacherouf hocinehacherouf enabled auto-merge (squash) February 6, 2023 16:06
@hocinehacherouf hocinehacherouf merged commit e4dbabb into main Feb 6, 2023
@hocinehacherouf hocinehacherouf deleted the Feature/1659_remove_blazored_modal branch February 6, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: Remove Blazored.Modal reference from client
2 participants