Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable search on concentrator page #1755

Merged
merged 5 commits into from
Feb 15, 2023

Conversation

GuillaumeM-2ISA
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 90.97% // Head: 91.03% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (4aa652a) compared to base (9271f83).
Patch coverage: 92.59% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1755      +/-   ##
==========================================
+ Coverage   90.97%   91.03%   +0.05%     
==========================================
  Files         270      273       +3     
  Lines        8855     8898      +43     
==========================================
+ Hits         8056     8100      +44     
+ Misses        799      798       -1     
Impacted Files Coverage Δ
...es/LoRaWAN/Concentrator/ConcentratorListPage.razor 69.56% <63.63%> (+5.63%) ⬆️
.../Components/Concentrators/ConcentratorSearch.razor 100.00% <100.00%> (ø)
...Hub.Portal.Client/Models/ConcentratorSearchInfo.cs 100.00% <100.00%> (ø)
...ers/v1.0/LoRaWAN/LoRaWANConcentratorsController.cs 100.00% <100.00%> (ø)
...rtal.Server/Services/LoRaWANConcentratorService.cs 100.00% <100.00%> (ø)
...l.Shared/Models/v1.0/Filters/ConcentratorFilter.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GuillaumeM-2ISA GuillaumeM-2ISA marked this pull request as ready for review February 15, 2023 08:53
@GuillaumeM-2ISA GuillaumeM-2ISA requested a review from a team as a code owner February 15, 2023 08:53
@hocinehacherouf hocinehacherouf marked this pull request as draft February 15, 2023 14:47
@hocinehacherouf hocinehacherouf marked this pull request as ready for review February 15, 2023 15:05
@hocinehacherouf hocinehacherouf force-pushed the Feature/1751_enable_search_concentrators branch from 52d4036 to 4aa652a Compare February 15, 2023 15:07
@hocinehacherouf hocinehacherouf enabled auto-merge (squash) February 15, 2023 15:08
@hocinehacherouf hocinehacherouf merged commit ee3547a into main Feb 15, 2023
@hocinehacherouf hocinehacherouf deleted the Feature/1751_enable_search_concentrators branch February 15, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants