Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1770 enable search sort device models #1781

Merged
merged 11 commits into from
Feb 23, 2023

Conversation

GuillaumeM-2ISA
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 91.04% // Head: 91.12% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (385e9a5) compared to base (d3decf6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1781      +/-   ##
==========================================
+ Coverage   91.04%   91.12%   +0.08%     
==========================================
  Files         274      277       +3     
  Lines        8910     8993      +83     
==========================================
+ Hits         8112     8195      +83     
  Misses        798      798              
Impacted Files Coverage Δ
...nt/Components/DeviceModels/DeviceModelSearch.razor 100.00% <100.00%> (ø)
...THub.Portal.Client/Models/DeviceModelSearchInfo.cs 100.00% <100.00%> (ø)
...onfigurations/CreateDeviceConfigurationsPage.razor 53.46% <100.00%> (ø)
...lient/Pages/DeviceModels/DeviceModelListPage.razor 98.52% <100.00%> (+1.09%) ⬆️
...Portal.Client/Pages/Devices/CreateDevicePage.razor 70.86% <100.00%> (+0.12%) ⬆️
...b.Portal.Client/Pages/Devices/DeviceListPage.razor 88.43% <100.00%> (ø)
...ortal.Client/Services/DeviceModelsClientService.cs 100.00% <100.00%> (ø)
...rver/Controllers/v1.0/DeviceModelControllerBase.cs 100.00% <100.00%> (ø)
....Server/Controllers/v1.0/DeviceModelsController.cs 100.00% <100.00%> (ø)
...lers/v1.0/LoRaWAN/LoRaWANDeviceModelsController.cs 100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GuillaumeM-2ISA GuillaumeM-2ISA marked this pull request as ready for review February 23, 2023 12:52
@GuillaumeM-2ISA GuillaumeM-2ISA requested a review from a team as a code owner February 23, 2023 12:52
@kbeaugrand kbeaugrand force-pushed the Feature/1770_enable_search_sort_device_models branch from 272e0e2 to 385e9a5 Compare February 23, 2023 14:46
@kbeaugrand kbeaugrand merged commit 3a974aa into main Feb 23, 2023
@kbeaugrand kbeaugrand deleted the Feature/1770_enable_search_sort_device_models branch February 23, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants