Fix #1804 - encapsulate sync job by a try-catch per device #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbeaugrand
force-pushed
the
fix/1804_make_edge_device_sync_job_more_resilient
branch
from
a325a7c to
a165d38
Compare
Codecov ReportBase: 91.12% // Head: 91.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1809 +/- ##
==========================================
+ Coverage 91.12% 91.21% +0.08%
==========================================
Files 277 277
Lines 8993 9004 +11
==========================================
+ Hits 8195 8213 +18
+ Misses 798 791 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kbeaugrand
force-pushed
the
fix/1804_make_edge_device_sync_job_more_resilient
branch
from
a165d38 to
4b25de9
Compare
kbeaugrand
force-pushed
the
fix/1804_make_edge_device_sync_job_more_resilient
branch
from
4b25de9 to
a810d04
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| var mockJobExecutionContext = MockRepository.Create<IJobExecutionContext>(); | ||
|
|
||
| var expectedDeviceModel = Fixture.Create<EdgeDeviceModel>(); | ||
| var fakeTwin = Fixture.Create<Twin>(); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable
| .Returns(Task.CompletedTask); | ||
|
|
||
| _ = this.mockEdgeDeviceModelRepository.Setup(c => c.GetByIdAsync(It.IsAny<string>())) | ||
| .ReturnsAsync((EdgeDeviceModel)null); |
Check warning
Code scanning / CodeQL
Useless upcast
hocinehacherouf
approved these changes
Feb 27, 2023
hocinehacherouf
deleted the
fix/1804_make_edge_device_sync_job_more_resilient
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What's new?
What kind of change does this PR introduce?