Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1831 - Failed to create new device #1834

Merged
merged 6 commits into from
Mar 2, 2023

Conversation

GuillaumeM-2ISA
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10 🎉

Comparison is base (d85d54c) 91.27% compared to head (56a6f75) 91.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1834      +/-   ##
==========================================
+ Coverage   91.27%   91.37%   +0.10%     
==========================================
  Files         277      277              
  Lines        9028     9031       +3     
==========================================
+ Hits         8240     8252      +12     
+ Misses        788      779       -9     
Impacted Files Coverage Δ
...Portal.Client/Pages/Devices/CreateDevicePage.razor 75.10% <100.00%> (+4.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand changed the title fix create device page Fix #1831 - Failed to create new device Mar 1, 2023
@GuillaumeM-2ISA GuillaumeM-2ISA marked this pull request as ready for review March 1, 2023 15:56
@GuillaumeM-2ISA GuillaumeM-2ISA requested a review from a team as a code owner March 1, 2023 15:56
@kbeaugrand kbeaugrand force-pushed the Bugfix/1831_fix_create_device branch from d26d2e8 to fdb2ecd Compare March 2, 2023 06:26
@GuillaumeM-2ISA GuillaumeM-2ISA merged commit 099a722 into main Mar 2, 2023
@GuillaumeM-2ISA GuillaumeM-2ISA deleted the Bugfix/1831_fix_create_device branch March 2, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants