Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug: Failed to delete a device that is not present in IoT Hub #1836 #1839

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

GuillaumeM-2ISA
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (4323ea0) 91.38% compared to head (4fc479f) 91.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1839   +/-   ##
=======================================
  Coverage   91.38%   91.39%           
=======================================
  Files         277      277           
  Lines        9046     9054    +8     
=======================================
+ Hits         8267     8275    +8     
  Misses        779      779           
Impacted Files Coverage Δ
...zureIoTHub.Portal.Server/Services/DeviceService.cs 100.00% <100.00%> (ø)
...IoTHub.Portal.Server/Services/DeviceServiceBase.cs 97.50% <100.00%> (+0.13%) ⬆️
...Hub.Portal.Server/Services/LoRaWanDeviceService.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GuillaumeM-2ISA GuillaumeM-2ISA marked this pull request as ready for review March 6, 2023 09:08
@GuillaumeM-2ISA GuillaumeM-2ISA requested a review from a team as a code owner March 6, 2023 09:08
@kbeaugrand kbeaugrand force-pushed the Bugfix/1836_fix_delete_device branch from 44e09e6 to 4fc479f Compare March 6, 2023 09:09
@kbeaugrand kbeaugrand changed the title fix delete device Fix Bug: Failed to delete a device that is not present in IoT Hub #1836 Mar 6, 2023
@kbeaugrand kbeaugrand enabled auto-merge (squash) March 6, 2023 09:12
@kbeaugrand kbeaugrand merged commit 77b9268 into main Mar 6, 2023
@kbeaugrand kbeaugrand deleted the Bugfix/1836_fix_delete_device branch March 6, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants