Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process LoRa Message only if comming from a device and can be deserialized #1891

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Mar 14, 2023

Description

What's new?

  • Fix error in logs when trying to deserialize an event that is not coming from a LoRa device.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand force-pushed the fix/unable-to-deserialize-lora-telemetry branch 2 times, most recently from cf05c09 to fb11c0c Compare March 14, 2023 17:02
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (932822a) 91.56% compared to head (a8ff7a6) 91.58%.

❗ Current head a8ff7a6 differs from pull request most recent head 1b99e6e. Consider uploading reports for the commit 1b99e6e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1891      +/-   ##
==========================================
+ Coverage   91.56%   91.58%   +0.01%     
==========================================
  Files         276      277       +1     
  Lines        9045     9062      +17     
==========================================
+ Hits         8282     8299      +17     
  Misses        763      763              
Impacted Files Coverage Δ
...THub.Portal.Infrastructure/ConnectionAuthMethod.cs 100.00% <100.00%> (ø)
...Hub.Portal.Server/Services/LoRaWanDeviceService.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand force-pushed the fix/unable-to-deserialize-lora-telemetry branch 5 times, most recently from c436918 to 0ff43fe Compare March 15, 2023 10:13
@kbeaugrand kbeaugrand marked this pull request as ready for review March 15, 2023 10:17
@kbeaugrand kbeaugrand requested a review from a team as a code owner March 15, 2023 10:17
@hocinehacherouf hocinehacherouf self-requested a review March 15, 2023 17:07
@kbeaugrand kbeaugrand force-pushed the fix/unable-to-deserialize-lora-telemetry branch 2 times, most recently from f24c4a0 to 7c4f0ac Compare March 16, 2023 06:53
@kbeaugrand kbeaugrand force-pushed the fix/unable-to-deserialize-lora-telemetry branch from a8ff7a6 to 1b99e6e Compare March 16, 2023 09:23
@hocinehacherouf hocinehacherouf merged commit 2ff9b1f into main Mar 16, 2023
@hocinehacherouf hocinehacherouf deleted the fix/unable-to-deserialize-lora-telemetry branch March 16, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants