Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor source code + Fix unit tests #1907

Merged
merged 10 commits into from
Mar 21, 2023
Merged

Refactor source code + Fix unit tests #1907

merged 10 commits into from
Mar 21, 2023

Conversation

GuillaumeM-2ISA
Copy link
Contributor

@GuillaumeM-2ISA GuillaumeM-2ISA commented Mar 16, 2023 •
edited by kbeaugrand
Loading

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Mar 16, 2023 •
edited
Loading

Codecov Report

Patch coverage: 94.07% and project coverage change: +0.04 🎉

Comparison is base (06dd095) 91.58% compared to head (c819433) 91.62%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1907      +/-   ##
==========================================
+ Coverage   91.58%   91.62%   +0.04%     
==========================================
  Files         277      277              
  Lines        9063     9114      +51     
==========================================
+ Hits         8300     8351      +51     
  Misses        763      763
Impacted Files Coverage Δ
src/AzureIoTHub.Portal.Client/App.razor 0.00% <0.00%> (ø)
...ub.Portal.Client/Handlers/ProblemDetailsHandler.cs 100.00% <ø> (ø)
...ureIoTHub.Portal.Client/Pages/Authentication.razor 0.00% <0.00%> (ø)
...ent/Pages/DeviceModels/DeleteDeviceModelPage.razor 0.00% <0.00%> (ø)
...zureIoTHub.Portal.Client/Services/LayoutService.cs 100.00% <ø> (ø)
src/AzureIoTHub.Portal.Client/Shared/Appbar.razor 80.00% <0.00%> (+3.80%) ⬆️
...Portal.Client/Validators/IoTEdgeModuleValidator.cs 73.91% <ø> (ø)
...nfrastructure/Services/LoRaWanManagementService.cs 85.18% <ø> (ø)
...ollers/v1.0/DeviceModelPropertiesControllerBase.cs 100.00% <ø> (ø)
...l.Server/Controllers/v1.0/DevicesControllerBase.cs 98.88% <ø> (ø)
... and 146 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GuillaumeM-2ISA GuillaumeM-2ISA changed the title Refactor shared library + fix unit tests Refactor source code + Fix unit tests Mar 16, 2023
@kbeaugrand kbeaugrand force-pushed the Story/1892_fix_warning_during_compilation branch from 3e1bf22 to 5a1cd36 Compare March 18, 2023 16:55
@kbeaugrand kbeaugrand temporarily deployed to E2E March 19, 2023 09:12 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand force-pushed the Story/1892_fix_warning_during_compilation branch from 4a0d5dc to b1df0ae Compare March 19, 2023 18:57
@kbeaugrand kbeaugrand temporarily deployed to E2E March 19, 2023 18:57 — with GitHub Actions Inactive
@GuillaumeM-2ISA GuillaumeM-2ISA temporarily deployed to E2E March 21, 2023 10:05 — with GitHub Actions Inactive
@GuillaumeM-2ISA GuillaumeM-2ISA temporarily deployed to E2E March 21, 2023 10:44 — with GitHub Actions Inactive
@GuillaumeM-2ISA GuillaumeM-2ISA temporarily deployed to E2E March 21, 2023 13:29 — with GitHub Actions Inactive
@GuillaumeM-2ISA GuillaumeM-2ISA temporarily deployed to E2E March 21, 2023 13:54 — with GitHub Actions Inactive
@GuillaumeM-2ISA GuillaumeM-2ISA temporarily deployed to E2E March 21, 2023 14:32 — with GitHub Actions Inactive
@GuillaumeM-2ISA GuillaumeM-2ISA temporarily deployed to E2E March 21, 2023 15:05 — with GitHub Actions Inactive
@GuillaumeM-2ISA GuillaumeM-2ISA marked this pull request as ready for review March 21, 2023 15:25
@GuillaumeM-2ISA GuillaumeM-2ISA requested a review from a team as a code owner March 21, 2023 15:25
@kbeaugrand kbeaugrand force-pushed the Story/1892_fix_warning_during_compilation branch from dad65fb to c819433 Compare March 21, 2023 17:57
@kbeaugrand kbeaugrand temporarily deployed to E2E March 21, 2023 17:57 — with GitHub Actions Inactive
kbeaugrand
kbeaugrand approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@kbeaugrand kbeaugrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kbeaugrand kbeaugrand enabled auto-merge (squash) March 21, 2023 18:00
@kbeaugrand kbeaugrand merged commit 34b9fa2 into main Mar 21, 2023
@kbeaugrand kbeaugrand deleted the Story/1892_fix_warning_during_compilation branch March 21, 2023 18:13
@developer-companion developer-companion bot mentioned this pull request Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbeaugrand kbeaugrand kbeaugrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeM-2ISA @kbeaugrand