Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1970 - Remove duplicated Frequency plan id for AU_915_928_FSB_8 #1971

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Mar 30, 2023

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand temporarily deployed to E2E March 30, 2023 08:51 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand force-pushed the fix/1970_fix_frequency_plan_id_for_australia branch from d0b7c26 to 626237c Compare March 30, 2023 08:51
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (05865d8) 91.62% compared to head (d0b7c26) 91.62%.

❗ Current head d0b7c26 differs from pull request most recent head 626237c. Consider uploading reports for the commit 626237c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1971   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files         277      277           
  Lines        9114     9114           
=======================================
  Hits         8351     8351           
  Misses        763      763           
Impacted Files Coverage Δ
...rs/v1.0/LoRaWAN/LoRaWANFrequencyPlansController.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand temporarily deployed to E2E March 30, 2023 09:01 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand marked this pull request as ready for review March 30, 2023 09:45
@kbeaugrand kbeaugrand requested a review from a team as a code owner March 30, 2023 09:45
@kbeaugrand kbeaugrand merged commit ef9dbbd into main Mar 30, 2023
@kbeaugrand kbeaugrand deleted the fix/1970_fix_frequency_plan_id_for_australia branch March 30, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: One of the Frequency Plan ID for AU915-928 is not named properly
2 participants