Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AU915-928 sub frequency channels #2236

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Jun 20, 2023

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand temporarily deployed to E2E June 20, 2023 16:49 — with GitHub Actions Inactive
@kbeaugrand
Copy link
Member Author

@adcoly,

As discussed together, I updated the frequency bands in radio configuration to match the documentation.
Please find below the expected frequencies:

image

Please let me know if I'm doing wrong.

@kbeaugrand kbeaugrand marked this pull request as ready for review June 20, 2023 16:52
@kbeaugrand kbeaugrand requested a review from a team as a code owner June 20, 2023 16:53
@kbeaugrand kbeaugrand requested a review from adcoly June 20, 2023 16:53
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b7833f1) 92.39% compared to head (eba327d) 92.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2236   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files         277      277           
  Lines        9129     9129           
=======================================
  Hits         8435     8435           
  Misses        694      694           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand temporarily deployed to E2E June 21, 2023 14:13 — with GitHub Actions Inactive
@kbeaugrand
Copy link
Member Author

Discussed internally frequencies for AU915 should be;

FSB 1

Channel Frequency (GHz)
Chanel 1 915.2
Chanel 2 915.4
Chanel 3 915.6
Chanel 4 915.8
Chanel 5 916.0
Chanel 6 916.2
Chanel 7 916.4
Chanel 8 916.6

FSB 2

Channel Frequency (GHz)
Chanel 1 916.8
Chanel 2 917.0
Chanel 3 917.2
Chanel 4 917.4
Chanel 5 917.6
Chanel 6 917.8
Chanel 7 918.0
Chanel 8 918.2

FSB 3

Channel Frequency (GHz)
Chanel 1 918.4
Chanel 2 918.6
Chanel 3 918.8
Chanel 4 919.0
Chanel 5 919.2
Chanel 6 919.4
Chanel 7 919.6
Chanel 8 919.8

FSB 4

Channel Frequency (GHz)
Chanel 1 920.0
Chanel 2 920.2
Chanel 3 920.4
Chanel 4 920.6
Chanel 5 920.8
Chanel 6 921.0
Chanel 7 921.2
Chanel 8 921.4

FSB 5

Channel Frequency (GHz)
Chanel 1 921.6
Chanel 2 921.8
Chanel 3 922.0
Chanel 4 922.2
Chanel 5 922.4
Chanel 6 922.6
Chanel 7 922.8
Chanel 8 923.0

FSB 6

Channel Frequency (GHz)
Chanel 1 923.2
Chanel 2 923.4
Chanel 3 923.6
Chanel 4 923.8
Chanel 5 924.0
Chanel 6 924.2
Chanel 7 924.4
Chanel 8 924.6

FSB 7

Channel Frequency (GHz)
Chanel 1 924.8
Chanel 2 925.0
Chanel 3 925.2
Chanel 4 925.4
Chanel 5 925.6
Chanel 6 925.8
Chanel 7 926.0
Chanel 8 926.2

FSB 8

Channel Frequency (GHz)
Chanel 1 926.4
Chanel 2 926.6
Chanel 3 926.8
Chanel 4 927.0
Chanel 5 927.2
Chanel 6 927.4
Chanel 7 927.6
Chanel 8 927.8

@kbeaugrand kbeaugrand force-pushed the fix/2194_incorrect_au_915_frequencies branch from 5b071dd to c76a575 Compare June 21, 2023 14:58
@kbeaugrand kbeaugrand temporarily deployed to E2E June 21, 2023 14:58 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand force-pushed the fix/2194_incorrect_au_915_frequencies branch from c76a575 to eba327d Compare June 23, 2023 05:41
@kbeaugrand kbeaugrand temporarily deployed to E2E June 23, 2023 05:41 — with GitHub Actions Inactive
@kbeaugrand kbeaugrand merged commit 0ba44ea into main Jun 23, 2023
@kbeaugrand kbeaugrand deleted the fix/2194_incorrect_au_915_frequencies branch June 23, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Wrong frequencies in AU915 FSB 2
1 participant