Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2675 - Unable to create edge device model since the module version is required #2676

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

TLeoDev
Copy link
Member

@TLeoDev TLeoDev commented Dec 5, 2023

Description

This Pull Request resolves the issue related to the automatic version management of IoT Edge modules by Azure. Previously, the Version field in IoTEdgeModule.cs was marked as required, which is no longer necessary since Azure manages this field automatically.

What kind of change does this PR introduce?

Details of the Change

The following line has been removed from IoTEdgeModule.cs:

[Required(ErrorMessage = "The component version is required.", AllowEmptyStrings = true)]

This change makes the Version field non-required, correcting the issue where the Version value was sometimes missing or improperly managed during the creation or updating of IoT Edge Device Models.

@TLeoDev TLeoDev added the bug Something isn't working label Dec 5, 2023
@TLeoDev TLeoDev added this to the The Portal Keepers - S02-E01 milestone Dec 5, 2023
@TLeoDev TLeoDev self-assigned this Dec 5, 2023
@TLeoDev TLeoDev requested a review from a team as a code owner December 5, 2023 10:42
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be7b2f9) 85.74% compared to head (c2e5481) 85.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2676   +/-   ##
=======================================
  Coverage   85.74%   85.74%           
=======================================
  Files         296      296           
  Lines       11338    11338           
  Branches      889      889           
=======================================
  Hits         9722     9722           
  Misses       1325     1325           
  Partials      291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kbeaugrand kbeaugrand changed the title fix #2675 Fix #2675 - Unable to create edge device model since the module version is requiered Dec 5, 2023
@kbeaugrand kbeaugrand changed the title Fix #2675 - Unable to create edge device model since the module version is requiered Fix #2675 - Unable to create edge device model since the module version is required Dec 5, 2023
@kbeaugrand kbeaugrand merged commit 0f615c6 into main Dec 5, 2023
6 checks passed
@kbeaugrand kbeaugrand deleted the fix/EdgeModelVersionField-2675 branch December 5, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants