Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Replace node build image by dotnet/sdk image #2885

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

  • Replace node build image by dotnet/sdk image to build IoT Hub Portal
  • Remove unused build params: -p:ClientAssetsRestoreCommand="npm ci"

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@hocinehacherouf hocinehacherouf requested a review from a team as a code owner March 8, 2024 19:34
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.87%. Comparing base (244ac48) to head (eea7aa2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2885   +/-   ##
=======================================
  Coverage   85.87%   85.87%           
=======================================
  Files         296      296           
  Lines       11344    11344           
  Branches      890      890           
=======================================
  Hits         9742     9742           
  Misses       1311     1311           
  Partials      291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kbeaugrand kbeaugrand force-pushed the Bugfix/fix_dockerfile branch from c604daf to 34bca52 Compare April 18, 2024 17:06
@kbeaugrand kbeaugrand force-pushed the Bugfix/fix_dockerfile branch from 34bca52 to 7c3da47 Compare April 21, 2024 16:27
@Metal-Mighty Metal-Mighty merged commit 7aa23fb into main Apr 23, 2024
6 checks passed
@Metal-Mighty Metal-Mighty deleted the Bugfix/fix_dockerfile branch April 23, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants