Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2942 - Add LoraWan service dependency before adding the http client #2943

Merged

Conversation

kbeaugrand
Copy link
Member

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand requested a review from a team as a code owner April 16, 2024 11:23
@kbeaugrand kbeaugrand force-pushed the dev/fix_2942_inject_http_client_for_lorawanManagementService branch 2 times, most recently from c24fa67 to 3ba5994 Compare April 16, 2024 11:54
@kbeaugrand kbeaugrand force-pushed the dev/fix_2942_inject_http_client_for_lorawanManagementService branch from 3ba5994 to 6431fc4 Compare April 16, 2024 11:55
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.63%. Comparing base (9d0170f) to head (3ba5994).

❗ Current head 3ba5994 differs from pull request most recent head 6431fc4. Consider uploading reports for the commit 6431fc4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2943   +/-   ##
=======================================
  Coverage   85.63%   85.63%           
=======================================
  Files         296      296           
  Lines       11340    11340           
  Branches      890      890           
=======================================
  Hits         9711     9711           
  Misses       1337     1337           
  Partials      292      292           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kbeaugrand kbeaugrand merged commit ed3da0e into main Apr 16, 2024
3 checks passed
@kbeaugrand kbeaugrand deleted the dev/fix_2942_inject_http_client_for_lorawanManagementService branch April 16, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: HttpClient is not correctly injected in LoRaWanManagementService
1 participant