Scheduler and plannings management (#3255) #3256
Conversation
* Add of layerId in device twin * #2998 Quartz migration for SendPlanningCommand * #2856 Disable built-in device model deletion * #3238 Update view when a device is unchecked * 3239 Allow to delete a planning from client * 3239 Allow to delete a planning * 2998 Schedule commands * #3239 Change checkboxes for layers displayed * Merge from main * 2516 add supportLoRaFeatures tag in template file * #3250 Import device list using the template given * #2985 Batch import creates ABP tags in Device Twin for OTAA-based device models * #3251 Import device - data overwritten * Unit tests * Update src/IoTHub.Portal.Infrastructure/Jobs/SendPlanningCommandJob.cs Co-authored-by: Kevin BEAUGRAND <9513635+kbeaugrand@users.noreply.github.com> * #2958 Remove 'Connection State' and 'Last status update' columns * #3023 startupOrder not supported in Edge Device Model schema --------- Co-authored-by: E068097 <julie.ramos_ext@michelin.com> Co-authored-by: judramos <ramos.julie.63@gmail.com>
kbeaugrand
force-pushed
the
main-vnext
branch
from
0cd18a2 to
d6f81cc
Compare
kbeaugrand
had a problem deploying
to
AWS Staging
GitHub Actions
Failure
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| foreach (var layer in Layers.Where(layer => layer.Planning == planningId)) | ||
| { | ||
| var updatedLayer = FindLayer(layer.Id); | ||
| updatedLayer.Planning = null; | ||
| await LayerClientService.UpdateLayer(updatedLayer); | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Select Note
| foreach (var schedule in schedules) | ||
| { | ||
| // Add schedules to the planning | ||
| if (schedule.PlanningId == planningCommand.planningId) addSchedule(schedule, planningCommand); | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Where Note
|
|
||
| var mockScheduleList = Fixture.CreateMany<ScheduleDto>(2).ToList(); | ||
|
|
||
| var deviceModels = Fixture.CreateMany<DeviceModelDto>(2).ToList(); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
| var expectedPaginatedDeviceModels = new PaginationResult<DeviceModelDto>() | ||
| { | ||
| Items = mockDeviceModel.ToList(), | ||
| TotalItems = mockDeviceModel.Count | ||
| }; |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
| public async Task LinkDeviceLayerDialog_Search_RendersCorrectlyAsync() | ||
| { | ||
| // Arrange | ||
| var searchedDevices = Fixture.CreateMany<TableData<DeviceListItem>>(3).ToList(); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
| public async Task LinkDeviceLayerDialog_Search_ShouldDisplayDevicesAsync() | ||
| { | ||
| // Arrange | ||
| var searchedDevices = Fixture.CreateMany<TableData<DeviceListItem>>(3).ToList(); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
| public async Task LinkDeviceLayerDialog_Save_UpdatesDevices() | ||
| { | ||
| // Arrange | ||
| var searchedDevices = Fixture.CreateMany<TableData<DeviceListItem>>(3).ToList(); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
Add of layerId in device twin
Story: Add a scheduler to apply configuration at desired times or intervals #2998 Quartz migration for SendPlanningCommand
Bug: Built-in device model can be removed #2856 Disable built-in device model deletion
Bug: Layers management - view not updated when a device is unselected in popup #3238 Update view when a device is unchecked
3239 Allow to delete a planning from client
3239 Allow to delete a planning
2998 Schedule commands
Feature: Plannings - allow to delete a planning #3239 Change checkboxes for layers displayed
Merge from main
2516 add supportLoRaFeatures tag in template file
Bug: Devices management - Can't import device list using the template given. #3250 Import device list using the template given
Bug: Batch import creates ABP tags in Device Twin for OTAA-based device models #2985 Batch import creates ABP tags in Device Twin for OTAA-based device models
Bug: Import device - data overwritten #3251 Import device - data overwritten
Unit tests
Update src/IoTHub.Portal.Infrastructure/Jobs/SendPlanningCommandJob.cs
Feature: Remove "Connection State" and "Last status update" columns #2958 Remove 'Connection State' and 'Last status update' columns
Bug: startupOrder not supported in Edge Device Model schema #3023 startupOrder not supported in Edge Device Model schema
Description
What's new?
What kind of change does this PR introduce?