Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the reference to the parameter isLoRaFeatureEnabled #548 #570

Merged
merged 1 commit into from
Apr 9, 2022

Conversation

hocinehacherouf
Copy link
Contributor

Deployment of the template fails because :

  • The template was referencing a non-existent variable called isLoRaFeatureEnabled: Referencing now an existing parameter with same name
  • A comma was missing

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Deployment of the template fails because :
- The template was referencing a non-existent variable called isLoRaFeatureEnabled: Referencing now an existing parameter with same name 
- A comma was missing
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner April 9, 2022 15:49
@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #570 (c386c46) into main (06e522b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #570   +/-   ##
=======================================
  Coverage   61.46%   61.46%           
=======================================
  Files         120      120           
  Lines        3846     3846           
=======================================
  Hits         2364     2364           
  Misses       1482     1482           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06e522b...c386c46. Read the comment docs.

@kbeaugrand kbeaugrand merged commit ddf4095 into main Apr 9, 2022
@kbeaugrand kbeaugrand deleted the 548_fix_arm_template branch April 9, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Failed to deploy template from Deploy button on main page
2 participants