Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework exceptions on DeviceModelPropertiesController #742 #748

Merged

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Feature

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #748 (156e61e) into main (b6bf6d9) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #748      +/-   ##
==========================================
+ Coverage   68.59%   68.84%   +0.24%     
==========================================
  Files         140      140              
  Lines        4605     4629      +24     
==========================================
+ Hits         3159     3187      +28     
+ Misses       1446     1442       -4     
Impacted Files Coverage Δ
...ollers/v1.0/DeviceModelPropertiesControllerBase.cs 100.00% <100.00%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6bf6d9...156e61e. Read the comment docs.

@hocinehacherouf hocinehacherouf marked this pull request as ready for review May 24, 2022 21:31
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner May 24, 2022 21:31
@hocinehacherouf hocinehacherouf merged commit 900a05f into main May 25, 2022
@hocinehacherouf hocinehacherouf deleted the feature/742_rework_exceptions_on_device_model_properties branch May 25, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants