Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #740 rework concentrator exception #761

Merged
merged 2 commits into from
Jun 2, 2022
Merged

fix #740 rework concentrator exception #761

merged 2 commits into from
Jun 2, 2022

Conversation

Sben65
Copy link
Contributor

@Sben65 Sben65 commented Jun 1, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Feature

@Sben65 Sben65 linked an issue Jun 1, 2022 that may be closed by this pull request
Rework exceptions on lorawan concentrators #740
Closed
@codecov
Copy link

codecov bot commented Jun 1, 2022 •
edited
Loading

Codecov Report

Merging #761 (9263999) into main (052c982) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
+ Coverage   69.55%   69.64%   +0.08%     
==========================================
  Files         139      139              
  Lines        4622     4622              
==========================================
+ Hits         3215     3219       +4     
+ Misses       1407     1403       -4
Impacted Files Coverage Δ
...ers/v1.0/LoRaWAN/LoRaWANConcentratorsController.cs 89.74% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 052c982...9263999. Read the comment docs.

@Sben65 Sben65 marked this pull request as ready for review June 1, 2022 13:06
@Sben65 Sben65 requested a review from a team as a code owner June 1, 2022 13:06
@kbeaugrand kbeaugrand force-pushed the issue#740_rework_exception_on_Concentrator branch from 2665c13 to 8c1596d Compare June 1, 2022 16:36
kbeaugrand
kbeaugrand reviewed Jun 1, 2022
View reviewed changes
Copy link
Member

@kbeaugrand kbeaugrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see only changes on the unit test, is this expected ?

@Sben65
Copy link
Contributor Author

Sben65 commented Jun 2, 2022

This is what was expected.

@kbeaugrand kbeaugrand self-requested a review June 2, 2022 08:57
@Sben65 Sben65 merged commit a09296f into main Jun 2, 2022
@Sben65 Sben65 deleted the issue#740_rework_exception_on_Concentrator branch June 2, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbeaugrand kbeaugrand kbeaugrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rework exceptions on lorawan concentrators
3 participants
@Sben65 @kbeaugrand @hocinehacherouf